Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=188189 #14314

Merged
merged 16 commits into from
Nov 30, 2018
Merged

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=188189 #14314

merged 16 commits into from
Nov 30, 2018

Conversation

darsh7807
Copy link
Contributor

@darsh7807 darsh7807 commented Nov 30, 2018

@darsh7807
Copy link
Contributor Author

This PR is same as #14221,
I messed up git history in previous PR so created new one

assert_true(Array.isArray(recordsList));
assert_equals(recordsList.length, 1);
assert_true(Array.isArray(recordsList[0]));
console.log(recordsList[0]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this done on purpose?

This is causing a lint error: https://travis-ci.org/web-platform-tests/wpt/jobs/461907141#L508

Copy link
Contributor Author

@darsh7807 darsh7807 Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it for debugging of the test, not needed now, so I am removing it.

</script>
</body>
</html>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove this extra line at the end?

Copy link
Contributor Author

@darsh7807 darsh7807 Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I removed it

Copy link
Contributor

@fred-wang fred-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Can you please open a bug on https://bugs.chromium.org/p/chromium for the remaining failing test on chromium and cc' the relevant people.
#14221 (comment)
#14221 (comment)

@fred-wang fred-wang merged commit aec5b0d into web-platform-tests:master Nov 30, 2018
@darsh7807
Copy link
Contributor Author

@fred-wang Created issue https://bugs.chromium.org/p/chromium/issues/detail?id=91082,
I am not able to find the option to cc people.

@rniwa
Copy link
Contributor

rniwa commented Dec 3, 2018

That can't be right. The issue has been closed in 2012.

@darsh7807
Copy link
Contributor Author

@fred-wang Created issue https://bugs.chromium.org/p/chromium/issues/detail?id=91082,
I am not able to find the option to cc people.

Sorry I missed the 3 at the end of link, correct link is
https://bugs.chromium.org/p/chromium/issues/detail?id=910823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants