-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=188189 #14314
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=188189 #14314
Conversation
Copied file from master
This PR is same as #14221, |
assert_true(Array.isArray(recordsList)); | ||
assert_equals(recordsList.length, 1); | ||
assert_true(Array.isArray(recordsList[0])); | ||
console.log(recordsList[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this done on purpose?
This is causing a lint error: https://travis-ci.org/web-platform-tests/wpt/jobs/461907141#L508
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it for debugging of the test, not needed now, so I am removing it.
</script> | ||
</body> | ||
</html> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please remove this extra line at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Can you please open a bug on https://bugs.chromium.org/p/chromium for the remaining failing test on chromium and cc' the relevant people.
#14221 (comment)
#14221 (comment)
@fred-wang Created issue https://bugs.chromium.org/p/chromium/issues/detail?id=91082, |
That can't be right. The issue has been closed in 2012. |
Sorry I missed the 3 at the end of link, correct link is |
WebKit export from bug: Perform a microtask checkpoint before creating a custom element