HTML: window.open() can set opener of a nested browsing context #15078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
zcorpan
reviewed
Jan 25, 2019
|
The Chrome failure here is https://bugs.chromium.org/p/chromium/issues/detail?id=475556. I filed https://bugs.webkit.org/show_bug.cgi?id=193963 on Safari. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Jan 29, 2019
Some initial work to make introducing browsing context groups (see #4198) easier. Fixes #2636 by making opener browsing context more generally applicable and making window.open() set it. Fixes #2645 by removing creator browsing context and explicitly passing in the creator document. Tests: web-platform-tests/wpt#15078.
domenic
approved these changes
Jan 30, 2019
|
They're both named targeting, but one of them ends up setting opener and the other doesn't. This was one of the changes with browsing context refactoring, that |
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
Some initial work to make introducing browsing context groups (see whatwg#4198) easier. Fixes whatwg#2636 by making opener browsing context more generally applicable and making window.open() set it. Fixes whatwg#2645 by removing creator browsing context and explicitly passing in the creator document. Tests: web-platform-tests/wpt#15078.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
Some initial work to make introducing browsing context groups (see whatwg#4198) easier. Fixes whatwg#2636 by making opener browsing context more generally applicable and making window.open() set it. Fixes whatwg#2645 by removing creator browsing context and explicitly passing in the creator document. Tests: web-platform-tests/wpt#15078.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for whatwg/html#4284.