Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: nested browsing contexts name attribute #15392

Merged
merged 3 commits into from
Feb 15, 2019
Merged

HTML: nested browsing contexts name attribute #15392

merged 3 commits into from
Feb 15, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 14, 2019

No description provided.

annevk added a commit to whatwg/html that referenced this pull request Feb 14, 2019
Name attributes of elements that cna create nested browsing contexts are only to be considered when the nested browsing context is created.

Tests: web-platform-tests/wpt#15392.
@annevk
Copy link
Member Author

annevk commented Feb 14, 2019

It might be somewhat nice to extend this with cross-origin support. That'd require the frame to post the name to the parent and a state switcher in the listener that then does the various aspects of the test as you cannot get name cross-origin from a WindowProxy object. Does anyone think it'll matter if we already have same-origin coverage?

@domenic
Copy link
Member

domenic commented Feb 14, 2019

Still working through my queue of (really cool) PRs from you this morning, but I'll chime in quickly to say that I'm afraid cross-origin vs. same-origin goes through rather different code paths, at least in Chrome with site-isolation. So, it would be good to add.

I certainly wouldn't require you to add that before merging any spec or test PRs. But, if you don't want to do the extra work yourself, it'd be good to file a follow-up issue when we do merge.

@annevk
Copy link
Member Author

annevk commented Feb 14, 2019

That's a good point, let me try to revive what I had earlier and make it work, but might have to wait for tomorrow if I'm not done quickly.

@@ -0,0 +1,6 @@
<script>
const ident = new URL(location).searchParams.get("ident"),
post = () => parent.postMessage({ name, ident }, "*");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little unclear that this is equivalent to name: window.name so I'd suggest changing it to make it explicit.

annevk added a commit to whatwg/html that referenced this pull request Feb 15, 2019
Name attributes of elements that can create nested browsing contexts (embed, frame, iframe, object) are only to be considered when the nested browsing context is created.

Tests: web-platform-tests/wpt#15392.
@annevk annevk merged commit e18c05e into master Feb 15, 2019
@annevk annevk deleted the annevk/nbc-name branch February 15, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants