HTML: opener and discarded auxiliary browsing context #15518
Conversation
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
| assert_true(openerDescImmaterial.writable); | ||
| assert_true(openerDescImmaterial.enumerable); | ||
| assert_true(openerDescImmaterial.configurable); | ||
| testOpener(frameW, window, () => frame.remove()); | ||
|
|
||
| t.done(); |
There was a problem hiding this comment.
Can use t.step_func_done for this one too, right?
There was a problem hiding this comment.
No, due to different load event behavior (there's a comment to that effect).
|
This probably should not be merged until whatwg/html#4379 (comment) is resolved somehow. |
There was a problem hiding this comment.
This seems fine, modulo sorting out the close() behavior. I commented over in whatwg/html#4379 about what's going on there in Firefox...
| assert_equals(otherW.opener, null, "opener after removal"); | ||
| assert_equals(openerGet(), null, "opener after removal via directly invoking the getter"); | ||
|
|
||
| otherW.opener = null; |
There was a problem hiding this comment.
It's a little weird to do this after the opener is already asserted to be null, but I guess we were already testing that.
There was a problem hiding this comment.
Mainly to ensure the setter doesn't do anything weird. I could remove this if desired...
annevk
requested review from
bzbarsky and
domenic
and removed request for
bzbarsky
For whatwg/html#4379.