Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ui] Correct property name #17054

Merged

Conversation

jugglinmike
Copy link
Contributor

The test for the appearance property mistakenly referred to the vendor
prefixed version, -webkit-appearance. In addition to contradicting the
test name and metadata, this caused the test intended for
-webkit-appearance to reference the non-existent property
-webkit--webkit-appearance.

Correct both tests, using the suite's build process to generate the
-webkit-appearance test from the corrected version of the appearance
test.


Recent research has demonstrated that the menulist-button value is necessary for web compatibility.

This seems to be the only instance of this particular mistake:

$ git rev-parse HEAD
48af14aaebdbcaf90bc21d07965f7c16661f8d90
$ git grep -E 'moz-+moz'
$ git grep -E 'webkit-+webkit'
css/css-ui/webkit-appearance-menulist-button-002.html: #container > #drop-down-select { -webkit--webkit-appearance: none; -webkit--webkit-appearance: menulist-button; }
$

The test for the `appearance` property mistakenly referred to the vendor
prefixed version, `-webkit-appearance`. In addition to contradicting the
test name and metadata, this caused the test intended for
`-webkit-appearance` to reference the non-existent property
`-webkit--webkit-appearance`.

Correct both tests, using the suite's build process to generate the
`-webkit-appearance` test from the corrected version of the `appearance`
test.
@zcorpan
Copy link
Member

zcorpan commented May 29, 2019

Whooops. Good catch. This is a disadvantage of copy-paste programming.

@zcorpan zcorpan merged commit 1ec27af into web-platform-tests:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants