Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining IDL implements #17060

Merged
merged 3 commits into from
May 29, 2019
Merged

Remove remaining IDL implements #17060

merged 3 commits into from
May 29, 2019

Conversation

saschanaz
Copy link
Member

@gsnedders
Copy link
Member

@saschanaz the DOM XPath IDL changes don't seem quite in-sync with https://wiki.whatwg.org/wiki/DOM_XPath (and the changes there were made by you 🙂), and notably miss XPathEvaluator includes XPathEvaluatorBase, and don't expose it.

@saschanaz
Copy link
Member Author

don't seem quite in-sync with

I was to minimize diffs, but okay, I'll sync it.

notably miss XPathEvaluator includes XPathEvaluatorBase, and don't expose it.

Oops!

@gsnedders
Copy link
Member

Easier to avoid mistakes like that if it's just in sync!

gsnedders
gsnedders reviewed May 29, 2019
View reviewed changes
Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The domxpath changes LGTM. Can someone else review the dedicated-worker.idl changes, plz? (I presume there's some reason we have that rather than including html.idl in places, though having something that auto-extracted is annoying from a keeping-things-in-sync point-of-view.)

@foolip
Copy link
Member

foolip commented May 29, 2019

dedicated-worker.idl should be deleted, I just haven't gotten around to it yet. It's not auto-updated, and as evidenced here that can cause trouble. But the changes LGTM.

@foolip foolip merged commit 41b92e5 into web-platform-tests:master May 29, 2019
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
@saschanaz
Remove remaining IDL implements (#17060)
da8baef 
Syncs XPath with WHATWG wiki.
foolip added a commit that referenced this pull request Apr 21, 2021
@foolip
[idlharness.js] remove support from implements statements
82f08a7 
The last of these were removed in #17060.
@foolip foolip mentioned this pull request Apr 21, 2021
Merged
foolip added a commit that referenced this pull request Apr 21, 2021
@foolip
[idlharness.js] remove support for implements statements
3acb18c 
The last of these were removed in #17060.
foolip added a commit that referenced this pull request Apr 22, 2021
@foolip
[idlharness.js] remove support for implements statements (#28619)
684b773 
The last of these were removed in #17060.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 25, 2021
@foolip @moz-wptsync-bot
Bug 1706609 [wpt PR 28619] - [idlharness.js] remove support for imple…
c8dfd05 
…ments statements, a=testonly

Automatic update from web-platform-tests
[idlharness.js] remove support for implements statements (#28619)

The last of these were removed in web-platform-tests/wpt#17060.
--

wpt-commits: 684b773116541669815c55c1e3e70b3dc8890250
wpt-pr: 28619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders gsnedders left review comments

@foolip foolip foolip approved these changes

@deniak deniak Awaiting requested review from deniak

@lukebjerring lukebjerring Awaiting requested review from lukebjerring

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@gsnedders gsnedders

Labels
domxpath interfaces wg-dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschanaz @gsnedders @foolip @wpt-pr-bot