Add cross-origin-embedder-policy tests with service workers #18559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
|
So all these async functions return a promise resolved with undefined unless something threw an exception. I guess that's fine and not a problem as the only failure condition here is throwing (right?), but it's not really clear to me why this is preferable over not having an async function and simply returning the inner statement. I'll do a more in depth look as well. |
annevk
approved these changes
Aug 20, 2019
nhiroki
reviewed
Aug 20, 2019
16 tasks
nhiroki
reviewed
Aug 21, 2019
html/cross-origin-embedder-policy/none-sw-from-require-corp.https.html
Outdated
Show resolved
Hide resolved
html/cross-origin-embedder-policy/require-corp-sw-from-none.https.html
Outdated
Show resolved
Hide resolved
html/cross-origin-embedder-policy/require-corp-sw-from-require-corp.https.html
Outdated
Show resolved
Hide resolved
|
Thanks! |
|
@yutakahirano you forgot to remove |
|
Oops, sorry. I will remove it. |
Merged
|
I uploaded #18586. |
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.