Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebCryptoAPI] Defer harness completion #19904

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

jugglinmike
Copy link
Contributor

This change ensures that all subtests are executed when the tests are
evaluated in dedicated worker contexts.

This change ensures that all subtests are executed when the tests are
evaluated in dedicated worker contexts.
@foolip
Copy link
Member

foolip commented Nov 1, 2019

wpt-firefox-nightly-stability is failing on Taskcluster. There were only 4 affected tests and yet we got "Task timeout after 7200 seconds. Force killing container."

These are the actual tests that were run, after expanding multi-globals and variants:

/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any.html
/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any.worker.html
/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.any.html
/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.any.worker.html
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.html?1-1000
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.html?1001-2000
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.html?2001-3000
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.html?3001-last
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker.html?1-1000
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker.html?1001-2000
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker.html?2001-3000
/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker.html?3001-last
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?1-1000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?1001-2000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?2001-3000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?3001-4000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?4001-5000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?5001-6000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?6001-7000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?7001-8000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?8001-last
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?1-1000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?1001-2000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?2001-3000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?3001-4000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?4001-5000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?5001-6000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?6001-7000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?7001-8000
/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker.html?8001-last

The live_backing.log.txt is a huge 975MB file with ~9.5 million lines...

@jugglinmike I don't think this is because of your changes at all, but can you file an issue about the stability job being unable to run these tests to completion? If it keeps coming up maybe we should fix it somehow.

@jugglinmike
Copy link
Contributor Author

Sure, see gh-20052.

@jimsch: I'm able to merge this despite the CI failure, but I'd like to confirm with you before doing so. Does this patch look okay to you?

@jimsch
Copy link
Contributor

jimsch commented Nov 1, 2019

I just did a re-review and I think that the patch will produce the same set of tests to be run. I would go ahead and integrate if you can live with the failures.

@jugglinmike
Copy link
Contributor Author

Excellent. Thanks!

@jugglinmike jugglinmike merged commit 0b2fcd3 into web-platform-tests:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants