[mediacapture-streams] Refactor test #19915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
jan-ivar and
youennf
foolip
requested changes
Oct 26, 2019
| @@ -7,6 +7,7 @@ | |||
| </head> | |||
| <body> | |||
| <script> | |||
| setup({ single_test: true }); | |||
There was a problem hiding this comment.
I'd prefer wrapping in test(() => {})
testharness.js was recently extended with an API to explicitly opt-in to the "single page test" feature [1]. As per WPT RFC 28 [2], tests which do not use this API and which do not declare any subtests will soon be reported as a harness error. Update the tests which previously opted in implicitly to instead declare a single subtest (so that it is no longer a single-page test). [1] web-platform-tests#19449 [2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md
jugglinmike
force-pushed
the
single-test-opt-in-mediacapture-streams
branch
from
640e7a8
to
3d1d676
Compare
|
You got it. Since the commit message would no longer describe this solution, I've amended the proposed commit and force-pushed the result to this branch. The original version of this branch is available here. |
jugglinmike
changed the title
foolip
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.
Update the tests which previously opted in implicitly to instead declare
a single subtest (so that it is no longer a single-page test).
[1] #19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md