Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts] Add tests for standard font families #19917

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

litherum
Copy link
Contributor

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the specific issues with notref tests, these look good to me.

css/css-fonts/standard-font-family-3.html Outdated Show resolved Hide resolved
css/css-fonts/standard-font-family-10.html Outdated Show resolved Hide resolved
@foolip
Copy link
Member

foolip commented Nov 21, 2019

Ah, so the reason Taskcluster isn't running is probably because the branch is old and needs to be rebased. See web-platform-tests/wpt-pr-bot#81 for tooling that might make this easier.

@foolip
Copy link
Member

foolip commented Nov 21, 2019

I've rebased the branch now, just need to wait for all checks to pass. @litherum feel free to merge yourself when the button is green :)

@foolip
Copy link
Member

foolip commented Nov 21, 2019

Results are in now: https://wpt.fyi/results/css/css-fonts?label=pr_head&max-count=1&pr=19917

@litherum the status seems to be the same for all browsers, is that what you expected?

wpt-chrome-dev-stability is failing on Taskcluster like this:

Slow tests

Test Result Longest duration (ms) Timeout (ms)
/css/css-fonts/standard-font-family-7.html PASS 12290 10000

I don't know why that test would be slow, it doesn't do anything async even. @zcorpan FYI that the slow test check can give mysterious results.

I'll admin merge this (to override failing Taskcluster) once @litherum can confirm the results are as expected.

@litherum
Copy link
Contributor Author

@litherum the status seems to be the same for all browsers, is that what you expected?

Yes. My implementation hasn't made it into Safari Technology Preview yet.

@foolip
Copy link
Member

foolip commented Nov 22, 2019

Admin merging now, thanks for confirming @litherum!

@foolip foolip merged commit 21f50fc into web-platform-tests:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants