Commits on Apr 27, 2020

1. [wpt] enhanceents to check-layout-th.js …

   There are 3 enhancements that I've found useful.
   
   1. Warn if there are any unexpected  data-* attributes
   
   A common error is to have a typo in data-* attribute name.
   When this happens, test will pass, because attribute is never read.
   This enhancement prints a warning if unexpected attribute is found.
   
   Running this over the entire test suite, I've found several errors:
   
   css/css-grid/grid-definition/grid-auto-repeat-intrinsic-001.html
   css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-001.html
   css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002.html
   css/css-grid/grid-items/grid-items-relative-offsets-001.html
   css/css-grid/grid-items/grid-items-relative-offsets-002.html
   have data-expected-x, data-expected-y
   Tried replacing some of these with data-offset-x, and tests fail.
   
   css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002
   has data-offset-top
   
   2. highlight error on failure flag. Defaults to false.
   
   If set, this flag will draw an outline around failed Element.
   Useful when debugging pages with many elements.
   
   3. toggle printing dom on error.
   
   Sometimes, it is useful not to print dom on error for clarity.
   
   Change-Id: I8424aa2dc002f63fde18d0fc54bdfe77666ce951
   Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161379
   Reviewed-by: Philip Jägenstedt <[email protected]>
   Reviewed-by: Manuel Rego <[email protected]>
   Commit-Queue: Aleks Totic <[email protected]>
   Cr-Commit-Position: refs/heads/master@{#763069}

   

   Aleks Totic authored and chromium-wpt-export-bot committed Apr 27, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 88ef30d
   • Browse repository at this point

   Copy the full SHA

   88ef30d View commit details

   Browse the repository at this point in the history