Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix idlharness.js' handling of Float(32/64)Array types #23323

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fix idlharness.js' handling of Float(32/64)Array types #23323

merged 1 commit into from
Apr 30, 2020

Commits on Apr 30, 2020

  1. Fix idlharness.js' handling of Float(32/64)Array types 

    idlharness.js does not seem to correctly handle Float32Array and
Float64Array types. When an interface uses such types, the tests will
fail with the exception thrown from idlharness.js:1221:
`throw new IdlHarnessError("Unrecognized type " + type);`

The fix is to teach idlharness.js how to handle Float(32/64)Array types,
and, while at it, to teach it to handle other typed arrays.

Bug: 1074548
Change-Id: I549f6ae1ea13590207bd4f49b94439ad2a43a13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172163
Reviewed-by: Joshua Bell <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Commit-Queue: Piotr Bialecki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#764058}
    @bialpio @chromium-wpt-export-bot
    bialpio authored and chromium-wpt-export-bot committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    0f39ee6 View commit details
    Browse the repository at this point in the history