Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webrtc] remove unnecessary ctx.getImageData() call #23337

Merged
merged 1 commit into from
Apr 30, 2020
Merged

[webrtc] remove unnecessary ctx.getImageData() call #23337

merged 1 commit into from
Apr 30, 2020

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 30, 2020

alvestrand
alvestrand approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I remember - I had some debugging code here that was later deleted. This is a leftover.

@foolip
Copy link
Member Author

foolip commented Apr 30, 2020

Stability jobs are still running on Taskcluster and I expect Firefox will time out and any flakiness in Chrome is preexisting, so admin merging right away. (The other jobs passed.)

@foolip foolip merged commit a9f1e8c into master Apr 30, 2020
@foolip foolip deleted the foolip/pixel branch April 30, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand approved these changes

@agouaillard agouaillard Awaiting requested review from agouaillard

@guidou guidou Awaiting requested review from guidou

@henbos henbos Awaiting requested review from henbos

@jan-ivar jan-ivar Awaiting requested review from jan-ivar

@rwaldron rwaldron Awaiting requested review from rwaldron

@snuggs snuggs Awaiting requested review from snuggs

@youennf youennf Awaiting requested review from youennf

Assignees

@jan-ivar jan-ivar

Labels
webrtc wg-webrtc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foolip @alvestrand @jan-ivar @wpt-pr-bot