Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Function in IdlArray.prototype.assert_type_is #23399

Merged
merged 1 commit into from
May 5, 2020

Conversation

stephenmcgruer
Copy link
Contributor

Closes #23329

@stephenmcgruer
Copy link
Contributor Author

@domenic - can you try this out with your PR (you may need to rebase yours), and verify it works as expected? I'm not yet confident to do the full on 'default is value instanceof self[type]' but I checked Function specifically and it should work there.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed works!

@stephenmcgruer
Copy link
Contributor Author

Stability check failure is a timeout, admin-merging.

@stephenmcgruer stephenmcgruer merged commit 550e0b3 into master May 5, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/idlharness_function branch May 5, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized type "Function" in my idlharness tests
4 participants