-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipboard API Tests: Move permissions tests to WPT. #23617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
Since #20461 and #5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <[email protected]> Commit-Queue: Victor Costan <[email protected]> Reviewed-by: Victor Costan <[email protected]> Cr-Commit-Position: refs/heads/master@{#769171}
chromium-wpt-export-bot
changed the title
Clipbooard API Tests: Move permissions tests to WPT.
Clipboard API Tests: Move permissions tests to WPT.
May 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2200278
branch
from
May 15, 2020 06:26
653b172
to
27acc7f
Compare
A few of the new tests are flaky on Chrome dev: Unstable results
|
Files crbug.com/1083268. @Hexcles could you please admin merge? |
As per #23332 (comment), this flakiness should now be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.
Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.
This allows us to share our permissions tests with other browsers
testing using WPT.
Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#769171}