Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard API Tests: Move permissions tests to WPT. #23617

Merged
merged 1 commit into from
May 15, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 14, 2020

Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#769171}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#769171}
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Clipbooard API Tests: Move permissions tests to WPT. Clipboard API Tests: Move permissions tests to WPT. May 15, 2020
@LukeZielinski
Copy link
Contributor

A few of the new tests are flaky on Chrome dev:

Unstable results

Test Subtest Results Messages
/clipboard-apis/permissions/readText-denied.https.html OK: 9/10, TIMEOUT: 1/10
/clipboard-apis/permissions/readText-denied.https.html navigator.clipboard.readText() fails when permission denied PASS: 9/10, TIMEOUT: 1/10 Test timed out
/clipboard-apis/permissions/readText-granted.https.html navigator.clipboard.readText() succeeds when permission granted FAIL: 1/10, PASS: 9/10 promise_test: Unhandled rejection with value: object "NotAllowedError: Read permission denied."
/clipboard-apis/permissions/writeText-denied.https.html navigator.clipboard.writeText() fails when permission denied FAIL: 1/10, PASS: 9/10 assert_unreached: Should have rejected: undefined Reached unreachable code
/clipboard-apis/permissions/writeText-granted.https.html navigator.clipboard.writeText() succeeds when permission granted FAIL: 1/10, PASS: 9/10 promise_test: Unhandled rejection with value: object "NotAllowedError: Write permission denied."

@LukeZielinski
Copy link
Contributor

Files crbug.com/1083268. @Hexcles could you please admin merge?

@Hexcles Hexcles merged commit 290d036 into master May 15, 2020
@Hexcles Hexcles deleted the chromium-export-cl-2200278 branch May 15, 2020 15:22
@dway123
Copy link

dway123 commented May 19, 2020

As per #23332 (comment), this flakiness should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants