[Security][Coop] Browsing context switch reporting WPT #23670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 18, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2207451
branch
2 times, most recently
from
c9693f0
to
d9acb68
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2207451
branch
10 times, most recently
from
54eced9
to
0eb2590
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2207451
branch
5 times, most recently
from
9b67146
to
acefb9b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2207451
branch
from
acefb9b
to
207741b
Compare
This CL adds basic reporting tests for browsing context switches. It provides a reporting endpoint (report.py), and reusable helpers within reporting-common.js, allowing future tests. The helpers provided verify that expected report templates are present on the expected endpoints, and that no extraneous reports are present. This CL only convers the cases: Popup opened from pages with coop : Same-origin with report only navigating to * Same-origin (without report) navigatin to *-with report Follow ups will cover redirects (moved to follow up as it had timeout issues), other origins and iframe cases. Bug: 1076456 Change-Id: I7a39d4def20692d8628ce2406569638310684f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207451 Reviewed-by: Arthur Sonzogni <[email protected]> Commit-Queue: Pâris Meuleman <[email protected]> Auto-Submit: Pâris Meuleman <[email protected]> Cr-Commit-Position: refs/heads/master@{#776008}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2207451
branch
from
207741b
to
8cc2a71
Compare
|
The following test failed on wpt-chrome-dev-stability Slow tests
|
|
@stephenmcgruer The Taskcluster failure is caused by a timeout. I did see some failing tests in the log but there is no unstable result. Could you admin merge? #7660 |
|
Huh, I wanted to say that the correct action is to mark the test timeout=long, but it appears to already be so. Ok, admin-merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds basic reporting tests for browsing context switches.
It provides a reporting endpoint (report.py), and reusable helpers
within reporting-common.js, allowing future tests.
The helpers provided verify that expected report templates are present
on the expected endpoints, and that no extraneous reports are present.
This CL only convers the cases:
Popup opened from pages with coop :
Same-origin with report only navigating to *
Same-origin (without report) navigatin to *-with report
Follow ups will cover redirects (moved to follow up as it had timeout
issues), other origins and iframe cases.
Bug: 1076456
Change-Id: I7a39d4def20692d8628ce2406569638310684f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207451
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Pâris Meuleman <[email protected]>
Auto-Submit: Pâris Meuleman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#776008}