Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align prefers-color-scheme:no-preference tests with spec. #24024

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 6, 2020

The 'no-preference' value has been removed from the spec per resolution
in [1].

[1] w3c/csswg-drafts#3857 (comment)

Bug: 1091806
Change-Id: Id5fd41b93f14c7ee60d10aa4dae036558271c948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232924
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#775910}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The 'no-preference' value has been removed from the spec per resolution
in [1].

[1] w3c/csswg-drafts#3857 (comment)

Bug: 1091806
Change-Id: Id5fd41b93f14c7ee60d10aa4dae036558271c948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232924
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#775910}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 16f0e25 into master Jun 8, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2232924 branch June 8, 2020 04:19
whimboo added a commit to whimboo/puppeteer that referenced this pull request Jun 9, 2020
The 'no-preference' value has been removed from the spec per resolution
in [1]. The appropriate web-platform-tests [2] have already been updated.

[1] w3c/csswg-drafts#3857 (comment)
[2] web-platform-tests/wpt#24024
mathiasbynens pushed a commit to puppeteer/puppeteer that referenced this pull request Jun 9, 2020
The 'no-preference' value has been removed from the spec per resolution in [1]. The appropriate web-platform-tests [2] have already been updated.

[1] w3c/csswg-drafts#3857 (comment)
[2] web-platform-tests/wpt#24024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants