Fix wpt/html/coep/require-corp-about-{blank,srcdoc}.html #24392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 30, 2020
- platform/mac-mac10.13/.../require-corp-about-blank-expected.txt is redundant - it's same as the base expectation. - platform/mac-mac10.14/.../require-corp-about-blank-expected.txt is wrong - the test always fails on the platform (and the failures are suppressed by TestExpectations). - wpt/html/coep/require-corp-about-blank.html always fails because COEP is only effective on secure contexts (whatwg/html#4930). Rename it to wpt/html/coep/require-corp-about-blank.https.html - wpt/html/coep/require-corp-about-srcdoc.html always fails because COEP is only effective on secure contexts (whatwg/html#4930). Rename it to wpt/html/coep/require-corp-about-srcdoc.https.html - Remove redundant TestExpectations entries. Bug: 1086065, 626703 Change-Id: I5573dd4446f482acdde828404e0a88893897ce09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133 Auto-Submit: Yutaka Hirano <[email protected]> Reviewed-by: Makoto Shimazu <[email protected]> Commit-Queue: Yutaka Hirano <[email protected]> Cr-Commit-Position: refs/heads/master@{#783875}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2274133
branch
from
635d34b
to
f441bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is redundant - it's same as the base expectation.
is wrong - the test always fails on the platform (and the failures
are suppressed by TestExpectations).
COEP is only effective on secure contexts
(Secure Contexts and Cross-Origin-Embedder-Policy whatwg/html#4930). Rename it to
wpt/html/coep/require-corp-about-blank.https.html
COEP is only effective on secure contexts
(Secure Contexts and Cross-Origin-Embedder-Policy whatwg/html#4930). Rename it to
wpt/html/coep/require-corp-about-srcdoc.https.html
Bug: 1086065, 626703
Change-Id: I5573dd4446f482acdde828404e0a88893897ce09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133
Auto-Submit: Yutaka Hirano <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#783875}