-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebShare: Introduce web-share feature policy #24628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
eb856ad
to
d8e1b3c
Compare
@ericwilligers (@foolip maybe) I can't figure out what to do about the two CI fails above. One seems to be legit in crashing Chrome with these tests. |
The Chrome change hasn't landed yet. Chrome doesn't currently have a share service implementation on non-Android platforms, so on desktop platforms |
Ok, makes sense... @foolip, do you know if we can override the above tho? I'd like to land this so I have at least a test for the Gecko side. https://phabricator.services.mozilla.com/D84121 |
d8e1b3c
to
46c973a
Compare
I have updated the test so existing desktop Chrome fails with a TypeError instead of a crash. |
46c973a
to
190ceb6
Compare
share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated w3c/web-share#166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Ian Clelland <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Cr-Commit-Position: refs/heads/master@{#789872}
190ceb6
to
ddcfee6
Compare
This is already merged, but yes, it is possible to override failing CI checks with admin powers. When needed, you can ping me or someone else listed in https://web-platform-tests.org/admin/ |
share() requests fail with a rejected promise if the 'web-share'
feature is not enabled.
We define 'self' as the default feature policy for web-share.
The spec has been updated
w3c/web-share#166
Intent to Ship
https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ
Bug: 1079104
Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791
Commit-Queue: Eric Willigers <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#789872}