Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebShare: Introduce web-share feature policy #24628

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 16, 2020

share() requests fail with a rejected promise if the 'web-share'
feature is not enabled.

We define 'self' as the default feature policy for web-share.

The spec has been updated
w3c/web-share#166

Intent to Ship
https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ

Bug: 1079104
Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791
Commit-Queue: Eric Willigers <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#789872}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2299791 branch 2 times, most recently from eb856ad to d8e1b3c Compare July 18, 2020 03:21
@marcoscaceres
Copy link
Contributor

@ericwilligers (@foolip maybe) I can't figure out what to do about the two CI fails above. One seems to be legit in crashing Chrome with these tests.

@ewilligers
Copy link
Contributor

@ericwilligers (@foolip maybe) I can't figure out what to do about the two CI fails above. One seems to be legit in crashing Chrome with these tests.

The Chrome change hasn't landed yet.

Chrome doesn't currently have a share service implementation on non-Android platforms, so on desktop platforms navigator.share(...) will crash if navigator.share is enabled by flags or command line arguments, and the share doesn't reject with an exception due to permissions or types.

@marcoscaceres
Copy link
Contributor

Ok, makes sense... @foolip, do you know if we can override the above tho? I'd like to land this so I have at least a test for the Gecko side. https://phabricator.services.mozilla.com/D84121

@ewilligers
Copy link
Contributor

I have updated the test so existing desktop Chrome fails with a TypeError instead of a crash.

share() requests fail with a rejected promise if the 'web-share'
feature is not enabled.

We define 'self' as the default feature policy for web-share.

The spec has been updated
w3c/web-share#166

Intent to Ship
https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ

Bug: 1079104
Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791
Commit-Queue: Eric Willigers <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#789872}
@foolip
Copy link
Member

foolip commented Jul 20, 2020

Ok, makes sense... @foolip, do you know if we can override the above tho?

This is already merged, but yes, it is possible to override failing CI checks with admin powers. When needed, you can ping me or someone else listed in https://web-platform-tests.org/admin/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants