Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COOP] access reporting: fix flakes reporting.html #25834

Merged
merged 1 commit into from
Feb 22, 2021

Commits on Feb 19, 2021

  1. [COOP] access reporting: fix flakes reporting.html

    ---
    
    The WPT testharness.js is defining:
    ```
    WindowTestEnvironment.prototype._forEach_windows = function(callback) {
    // Iterate over the windows [self ... top, opener]. The callback is
    // passed two objects, the first one is the window object itself, the
    // second one is a boolean indicating whether or not it's on the same
    // origin as the (...)
    ```
    
    This causes some postMessage to be sent cross-window. They are reported
    and causes failures. For instance in reporting-observer.html test.
    
    This patch removes testharness.js from executor.html
    This fixed the issue for reporting-observer.html
    
    More generally, we shouldn't check access in between two windows, when
    one of them is using testharness.js
    
    ---
    
    Second discovery:
    The official web-platform-test runner sometimes drop POST requests
    when many are requested in parallel. Using a lock fixes the issue.
    
    ---
    
    Bug: 1090273
    Change-Id: I261b9bfece935e3613c250a3a9402a1c8a6ff14e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436742
    Commit-Queue: Arthur Sonzogni <[email protected]>
    Reviewed-by: Pâris Meuleman <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#855712}
    ArthurSonzogni authored and chromium-wpt-export-bot committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    a3f54a8 View commit details
    Browse the repository at this point in the history