[wptserve] Make .headers work with generated tests #26014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honour *.headers (including *.sub.headers and __dir__{.sub}.headers)
when serving tests automatically generated from *.js files. The
documentation doesn't mention this exception and reasonable people would
assume *.headers work the same way as with static files. Add a
functional test, too.
Fixes https://crbug.com/1135559.
Drive-by: some stylistic changes and docstrings.
stephenmcgruer
approved these changes
Oct 7, 2020
| @@ -73,7 +73,9 @@ def __call__(self, request, response): | |||
| self.handler(request, response) | |||
|
|
|||
| def handle_request(self, request, response): | |||
| for header_name, header_value in self.headers: | |||
| headers = self.headers + handlers.load_headers( | |||
There was a problem hiding this comment.
Optional: I'd consider renaming self.headers to something like self.base_headers. It's just a bit weird to say "these are the headers, but then we have to add more headers on-top to make up the headers".
There was a problem hiding this comment.
This is pretty much an implementation detail (despite being public), as it's not intended/suitable for direct use, so I'm not very worried about the name here.
Co-authored-by: Stephen McGruer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honour *.headers (including *.sub.headers and dir{.sub}.headers)
when serving tests automatically generated from *.js files. The
documentation doesn't mention this exception and reasonable people would
assume *.headers work the same way as with static files. Add a
functional test, too.
Fixes https://crbug.com/1135559.
Drive-by: some stylistic changes and docstrings.