[COOP] Fix reporting-observer.html #27893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 4, 2021
Stop using a WebLock for "send()", this isn't: - supported in cross-origin iframe. (causing this test to fail) - supported in Firefox (still experimental) - supported in Safari. Instead use pure JS. This is a copypaste of the same method for COEP credentialless, which has proven to be not flaky: /wpt/html/cross-origin-embedder-policy/credentialless/resources/dispatcher.js Bug: 1133342 Change-Id: Ib5c4eb6c76bb576bf1a21d44cb9bde1a63284d18 Fixed: 1133342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2735014 Reviewed-by: Pâris Meuleman <[email protected]> Commit-Queue: Arthur Sonzogni <[email protected]> Cr-Commit-Position: refs/heads/master@{#859726}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2735014
branch
from
7299abc
to
598fefd
Compare
|
I modified a common helper files used by every tests, and there was existing stability issues. See this previous answer for more details: @stephenmcgruer could you admin merge? |
Done, and apologies for missing this until today. Always happy to merge these, no problem about asking :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using a WebLock for "send()", this isn't:
Instead use pure JS. This is a copypaste of the same method for COEP
credentialless, which has proven to be not flaky:
/wpt/html/cross-origin-embedder-policy/credentialless/resources/dispatcher.js
Bug: 1133342
Change-Id: Ib5c4eb6c76bb576bf1a21d44cb9bde1a63284d18
Fixed: 1133342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2735014
Reviewed-by: Pâris Meuleman <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#859726}