Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of six.reraise #28887

Merged
merged 1 commit into from
May 10, 2021
Merged

Remove use of six.reraise #28887

merged 1 commit into from
May 10, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented May 7, 2021

Implementation of this for Python 3:

def reraise(tp, value, tb=None):
try:
if value is None:
value = tp()
if value.__traceback__ is not tb:
raise value.with_traceback(tb)
raise value
finally:
value = None
tb = None

Simplifying that step by step leads to the new code.

Part of #28776.

@foolip
Copy link
Member Author

foolip commented May 10, 2021

The apparent regressions for Firefox and Safari here are the same that I've seen a lot recently, see #28925. I'll admin merge this to bypass the failing stability checks, which timed out due to too many tests being affected.

@foolip foolip merged commit 402658b into master May 10, 2021
@foolip foolip deleted the foolip/six_reraise branch May 10, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants