Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that credential.id is base64-encoding of credential.rawId #29914

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Check that credential.id is base64-encoding of credential.rawId #29914

merged 2 commits into from
Dec 10, 2021

Conversation

dontcallmedom
Copy link
Contributor

nsatragno
nsatragno approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment. Good catch, thanks.

webauthn/helpers.js Outdated Show resolved Hide resolved
@dontcallmedom
Copy link
Contributor Author

@web-platform-tests/wpt-core-team I think this is failing due to #31499 - can you override the CI failure?

@dontcallmedom @nsatragno
Remove unused variable
c633159 
Co-authored-by: Nina Satragno <[email protected]>
@sideshowbarker sideshowbarker merged commit 8ae232e into web-platform-tests:master Dec 10, 2021
@dontcallmedom dontcallmedom deleted the checkbase64-crypto branch December 10, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsatragno nsatragno nsatragno approved these changes

@apowers313 apowers313 Awaiting requested review from apowers313

@jcjones jcjones Awaiting requested review from jcjones

Assignees

@jcjones jcjones

Labels
webauthn wg-webauthn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dontcallmedom @nsatragno @sideshowbarker @jcjones @wpt-pr-bot @moz-wptsync-bot