Convert adoptedStyleSheets to use ObservableArray #31737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 24, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3270424
branch
6 times, most recently
from
92d6128
to
5841e07
Compare
1 task
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3270424
branch
from
5841e07
to
f579c78
Compare
This CL converts adoptedStyleSheets from a FrozenArray to the new ObservableArray. This is per the new spec [1]. It should be backwards compatible, and will allow mutation of adoptedStyleSheets in place using regular array methods like .push(): document.adoptedStyleSheets = [sheet1, sheet2]; document.adoptedStyleSheets.push(sheet); ...etc... Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/8p7QvGn3Ezo [1] https://drafts.csswg.org/cssom/#extensions-to-the-document-or-shadow-root-interface Bug: 1201744 Bug: 1236777 Change-Id: Iacbf66a38c0abd477b5628224c97bec9f8a317e4 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270424 Reviewed-by: Yuki Shiino <[email protected]> Reviewed-by: Raphael Kubo Da Costa <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#950808}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3270424
branch
from
f579c78
to
115ffe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL converts adoptedStyleSheets from a FrozenArray to the
new ObservableArray. This is per the new spec [1]. It should be
backwards compatible, and will allow mutation of adoptedStyleSheets
in place using regular array methods like .push():
document.adoptedStyleSheets = [sheet1, sheet2];
document.adoptedStyleSheets.push(sheet);
...etc...
Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/8p7QvGn3Ezo
[1] https://drafts.csswg.org/cssom/#extensions-to-the-document-or-shadow-root-interface
Bug: 1201744
Bug: 1236777
Change-Id: Iacbf66a38c0abd477b5628224c97bec9f8a317e4
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270424
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Raphael Kubo Da Costa <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#950808}