Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify template to create canvas and offscreencanvas tests #31822

Merged
merged 1 commit into from
Dec 4, 2021

Commits on Dec 3, 2021

  1. Unify template to create canvas and offscreencanvas tests

    The typical way to add tests for canvas and offscreencanvas is as
    following:
    - write the test in yaml/element (create the test for canvas)
    - copy the the test to yaml/offscreencanvas
    - add t.done() to the end of test (create the test for offscreencanvas)
    
    This is because the API for canvas and offscreencanvas are mostly the
    same.
    
    This cl updates templates and gentestutils to allow the framework of
    generate canvas and offscreencanvas test from test.
    
    I removed both yaml/element/color_space.yaml and
    yaml/offscreencanvas/color_space.yaml and add yaml_new/color_space.yaml.
    Now the yaml_new/color_space.yaml generates the same results as before.
    
    Note that it's possible to add test for a particular canvas type
    by using canvasType as keyword.
    
    Bug: 1275750
    Change-Id: I6bf48ec3081f5fe3669bf585f92b39a712045c6b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307080
    Reviewed-by: Fernando Serboncini <[email protected]>
    Reviewed-by: Juanmi Huertas <[email protected]>
    Commit-Queue: Yi Xu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#947713}
    yiyix authored and past committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    f22c5ee View commit details
    Browse the repository at this point in the history