Port chrome-only dialog tests to WPT part 4 #31889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 4, 2021
nt1m
reviewed
Dec 4, 2021
html/semantics/interactive-elements/the-dialog-element/non-modal-dialog-layout.html
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,72 @@ | |||
| <!DOCTYPE html> | |||
| <link rel=author href="mailto:[email protected]"> | |||
There was a problem hiding this comment.
nit: Here and other tests, would be nice if double quotes were used around the attr value.
There was a problem hiding this comment.
I've been doing rel=author instead of rel="author" for years, is there a style guide or anything? I kind of like not using quotes with simple string values.
There was a problem hiding this comment.
not sure if there's a style guide (I wish there was), but attribute values most commonly have double quotes around them, not sure why smaller values should be exempt.
There was a problem hiding this comment.
ok, ill add quotes to all the dialog tests as a followup
There was a problem hiding this comment.
I created a followup to do this: #32043
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3314613
branch
3 times, most recently
from
d80dfaa
to
bff561b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3314613
branch
from
bff561b
to
dc5ce9c
Compare
Bug: 1240798 Change-Id: I6267d6ce10f1cdf3b326b8a8cbbf90054a47f658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314613 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#950887}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3314613
branch
from
dc5ce9c
to
5f339c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 1240798
Change-Id: I6267d6ce10f1cdf3b326b8a8cbbf90054a47f658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314613
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#950887}