Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7660 Avoid CI stability checks timing out #32202

Merged
merged 26 commits into from
Jan 11, 2022
Merged

7660 Avoid CI stability checks timing out #32202

merged 26 commits into from
Jan 11, 2022

Commits on Dec 27, 2021

  1. allow stability checks to avoid TC timeout by checking times in betwe… 

    …en repeat runs
    @DanielRyanSmith
    DanielRyanSmith committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    3058ead View commit details
    Browse the repository at this point in the history

  2. fix flake8 issue

    @DanielRyanSmith
    DanielRyanSmith committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    52e31bb View commit details
    Browse the repository at this point in the history

  3. remove empty flag to trigger stability checks

    @DanielRyanSmith
    DanielRyanSmith committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    33f8b1b View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. some commenting explaining how iterations are being tracked

    @DanielRyanSmith
    DanielRyanSmith committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    624e341 View commit details
    Browse the repository at this point in the history

  2. add --repeat-max-time flag

    @DanielRyanSmith
    DanielRyanSmith committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    11b8753 View commit details
    Browse the repository at this point in the history

  3. better descriptors for announcing results 

    If the repeat runs stop early to avoid, timeout, a message will be written in the results explaining so.
    @DanielRyanSmith
    DanielRyanSmith committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    c28794e View commit details
    Browse the repository at this point in the history

  4. cast max_time to timedelta

    @DanielRyanSmith
    DanielRyanSmith committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    e0b33e6 View commit details
    Browse the repository at this point in the history

  5. correct syntax for kwargs

    @DanielRyanSmith
    DanielRyanSmith committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    d357344 View commit details
    Browse the repository at this point in the history

  6. specify kwargs source for run_test_iteration

    @DanielRyanSmith
    DanielRyanSmith committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    02e4f87 View commit details
    Browse the repository at this point in the history

  7. remove empty css flags tag to trigger stability checks

    @DanielRyanSmith
    DanielRyanSmith committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    36db2c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Add clause to handle an ineffective number of iterations completing

    @DanielRyanSmith
    DanielRyanSmith committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    3f9bddb View commit details
    Browse the repository at this point in the history

  2. replace unassociated change used to trigger stability checks

    @DanielRyanSmith
    DanielRyanSmith committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    b3425cf View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Implement changes suggested by @stephenmcgruer

    @DanielRyanSmith
    DanielRyanSmith committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    c93f895 View commit details
    Browse the repository at this point in the history

  2. Add only necessary formatting changes to stability

    @DanielRyanSmith
    DanielRyanSmith committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    4d7e6f2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 7660-stability-timeout

    @DanielRyanSmith
    DanielRyanSmith committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    2252d91 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. wptrunner reformatting changes suggested by @jgraham

    @DanielRyanSmith
    DanielRyanSmith committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    2350b76 View commit details
    Browse the repository at this point in the history

  2. functional changes to stability tests suggested by @jgraham

    @DanielRyanSmith
    DanielRyanSmith committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    01a2f07 View commit details
    Browse the repository at this point in the history

  3. flake8 changes "line break before binary operator"

    @DanielRyanSmith
    DanielRyanSmith committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    2d9fe27 View commit details
    Browse the repository at this point in the history

  4. change run_tests to return counts object

    @DanielRyanSmith
    DanielRyanSmith committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    330124a View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2022

  1. ensure run_tests return values are properly accessed 

    Now that wptrunner's run_tests returns more than 1 value, the return type will be a tuple for the older variables that expect only 1 value. We need to ensure that we pull the expected first value (boolean) out of that tuple.
    @DanielRyanSmith
    DanielRyanSmith committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    899b794 View commit details
    Browse the repository at this point in the history

  2. run_tests has consistent return values even in fail cases 

    wptrunner's run_tests would return a tuple only if not issues arose while running, and would return only a boolean in the case of some expected issue. Now a tuple is returned in all instances as expected.
    @DanielRyanSmith
    DanielRyanSmith committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    42d9f5e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Return full counts in TestStatus class 

    run_tests will now return a new TestStatus object rather than returning only the number of iterations run. This will allow for more robust statistics to be shown in the future.
    @DanielRyanSmith
    DanielRyanSmith committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a13f488 View commit details
    Browse the repository at this point in the history

  2. small formatting changes 

    reducing some comments and logs to taking less vertical space.
    @DanielRyanSmith
    DanielRyanSmith committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    e9d90c8 View commit details
    Browse the repository at this point in the history

  3. small wording change 

    TestStatus docstring
    @DanielRyanSmith
    DanielRyanSmith committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    9d27581 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Replace counts with TestStatus object 

    forego the use of defaultdict counts keeping track of test info/results and instead use the custom class TestStatus.
    @DanielRyanSmith
    DanielRyanSmith committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9d11203 View commit details
    Browse the repository at this point in the history

  2. convert some log strings to f-strings

    @DanielRyanSmith
    DanielRyanSmith committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    6d00729 View commit details
    Browse the repository at this point in the history