Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report iframe resource timing also with 204/205 iframes, and don't report for download #33402

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 29, 2022

No description provided.

@noamr noamr assigned yoavweiss and unassigned mkruisselbrink Mar 29, 2022
@noamr noamr changed the title iframe rt failure Report iframe resource timing also with 204/205 iframes Mar 29, 2022
@noamr noamr changed the title Report iframe resource timing also with 204/205 iframes Report iframe resource timing also with 204/205 iframes, and don't report for download Mar 29, 2022
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noamr noamr merged commit cc4c71e into master Mar 29, 2022
@noamr noamr deleted the iframe-rt-failure branch March 29, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants