Commits on Mar 31, 2022

1. Implement parsing / serialization for container{,-type,-name} CSS pro… …

   …perties.
   
   Two noteworthy details that may seem random otherwise:
   
    * Moving values around in nsStyleDisplay is needed so that the struct
      remains under the size limit that we have to avoid jumping allocator
      buckets.
   
    * All the test expectation churn is because tests depend on
      `container-type: size` parsing to run, and now they run. Tests for
      the relevant bits I implemented are passing, with the only exception
      of some `container-name-computed.html` failures which are
      w3c/csswg-drafts#7181. Safari agrees with
      us there.
   
   Other notes when looking at the spec and seeing how it matches the
   implementation:
   
    * `container` syntax doesn't match spec, but matches tests and sanity:
      w3c/csswg-drafts#7180
   
    * `container-type` syntax doesn't _quite_ match spec, but matches tests
      and I think it's a spec bug since the definition for the missing
      keyword is gone:
      w3c/csswg-drafts#7179
   
   Differential Revision: https://phabricator.services.mozilla.com/D142419
   
   bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1762088
   gecko-commit: bdaf003569a7cd516ada250c6d73e5288a69b1ae
   gecko-reviewers: firefox-style-system-reviewers, layout-reviewers, boris

   

   emilio authored and moz-wptsync-bot committed Mar 31, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 8721569
   • Browse repository at this point

   Copy the full SHA

   8721569 View commit details

   Browse the repository at this point in the history