Commits on Jun 1, 2022

1. Convert popup=popup to popup=auto or just popup …

   Per the [1] resolution, `popup=popup` has been renamed to `popup=auto`.
   Additionally, per the [2] resolution, "boolean-like" behavior is also
   supported, such that `<div popup>` means the same thing as `<div popup=auto>`. This CL implements both of these changes.
   
   Note that this CL has one case that still needs to be fixed:
     <div id=foo popup=invalid>
     <script>
       foo.popup === null; // false, should be true
     </script>
   
   To fix the above, I need to figure out how to specify the ReflectMissing
   and ReflectInvalid values so that they mean "null".
   
   [1] openui/open-ui#491 (comment)
   [2] openui/open-ui#533 (comment)
   
   Bug: 1307772
   Change-Id: I6037c5322f7408ebd2c91690f89ecbc513c66bdb
   Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668816
   Auto-Submit: Mason Freed <[email protected]>
   Commit-Queue: Mason Freed <[email protected]>
   Reviewed-by: Joey Arhar <[email protected]>
   Reviewed-by: Aaron Leventhal <[email protected]>
   Reviewed-by: Yuki Shiino <[email protected]>
   Cr-Commit-Position: refs/heads/main@{#1009383}

   

   mfreed7 authored and chromium-wpt-export-bot committed Jun 1, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for d2bd43c
   • Browse repository at this point

   Copy the full SHA

   d2bd43c View commit details

   Browse the repository at this point in the history