Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple calls to subscribe() consumes user activation #34273

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Multiple calls to subscribe() consumes user activation #34273

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4f077a
Multiple calls to subscribe() consumes user activation
marcoscaceres Jun 1, 2022
d035b37
Update push-api/resources/simple_sw.js
marcoscaceres Dec 15, 2023
25eb7f3
Update push-api/resources/simple_sw.js
marcoscaceres Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions push-api/consume-transient-activation.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<!DOCTYPE html>
<meta charset="utf-8" />
<title>Test that transient activation is consumed</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<body>
<script>
async function clearRegistration() {
const reg = await navigator.serviceWorker.getRegistration(
"resources/simple_sw.js"
);
await reg.unregister();
}

promise_test(async (t) => {
const reg = await navigator.serviceWorker.register(
"resources/simple_sw.js"
);
t.add_cleanup(clearRegistration);
await reg.active;
await test_driver.bless("transient activation");

// consumes user activation
reg.pushManager.subscribe();

await promise_rejects_dom(
t,
"NotAllowedError",
reg.pushManager.subscribe()
);
}, `Subsequent calls to subscribe() consumes user activation`);
</script>
</body>
3 changes: 3 additions & 0 deletions push-api/resources/simple_sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
self. onpush = ( ) => {
marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved
// does nothing...
};