[Gecko Bug 1775327] Part 3: Do normalization for NormalizedTiming(). #34784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the normalization of the specified time, defined in [web-animations-2]: https://drafts.csswg.org/web-animations-2/#normalize-specified-timing. However, it is possible to update this, based on the spec issue: w3c/csswg-drafts#4862. For now, we just do normalization for delay, end delay, and iteration duration based on the end time. And make sure the end time is equal to the timeline duration. Differential Revision: https://phabricator.services.mozilla.com/D149685 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1775327 gecko-commit: 71bbfaecf629a3d73c72600d35c0ac2965516d60 gecko-reviewers: firefox-animation-reviewers, birtles
wpt-pr-bot
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the normalization of the specified time, defined in
[web-animations-2]:
https://drafts.csswg.org/web-animations-2/#normalize-specified-timing.
However, it is possible to update this, based on the spec issue:
w3c/csswg-drafts#4862.
For now, we just do normalization for delay, end delay, and
iteration duration based on the end time. And make sure the end time is
equal to the timeline duration.
Differential Revision: https://phabricator.services.mozilla.com/D149685
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1775327
gecko-commit: 71bbfaecf629a3d73c72600d35c0ac2965516d60
gecko-reviewers: firefox-animation-reviewers, birtles