Change the popup invalid value default to "manual"
#35629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 25, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3858445
branch
from
cd8dfbd
to
0dc69da
Compare
Per the resolution [1], invalid values should now be treated as if they were `popup=manual`. This lines up with the related change [2] to the UA stylesheet for pop-up. I also took the opportunity to expand the "basic" test to include adding the `popup` attribute on all (visible) element types. [1] openui/open-ui#533 (comment) [2] https://chromium-review.googlesource.com/c/chromium/src/+/3840811 Bug: 1307772 Change-Id: I6d5bf956e344f9256ab9cc1bf3d30655c8dee5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858445 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: David Baron <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1039838}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3858445
branch
from
0dc69da
to
c9beff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the resolution [1], invalid values should now be treated as
if they were
popup=manual. This lines up with the related change[2] to the UA stylesheet for pop-up.
I also took the opportunity to expand the "basic" test to include
adding the
popupattribute on all (visible) element types.[1] openui/open-ui#533 (comment)
[2] https://chromium-review.googlesource.com/c/chromium/src/+/3840811
Bug: 1307772
Change-Id: I6d5bf956e344f9256ab9cc1bf3d30655c8dee5bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858445
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1039838}