Add togglePopover() method for popovers #36808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 3, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4000073
branch
from
557e8a2
to
b9f406b
Compare
Per the resolution [1] there's a desire to add a togglePopover() convenience method. This CL adds that method plus tests. [1] openui/open-ui#610 (comment) Bug: 1307772 Change-Id: Icd39c766786e7d1f6475a86ca8a7a1e89b66182e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000073 Commit-Queue: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1067805}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4000073
branch
from
b9f406b
to
07885cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the resolution [1] there's a desire to add a togglePopover()
convenience method. This CL adds that method plus tests.
[1] openui/open-ui#610 (comment)
Bug: 1307772
Change-Id: Icd39c766786e7d1f6475a86ca8a7a1e89b66182e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000073
Commit-Queue: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1067805}