Implement dialog initial focus proposal #36831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 5, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3984630
branch
from
dda8213
to
7890990
Compare
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3984630
branch
2 times, most recently
from
14b3a2f
to
145f7f6
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3984630
branch
from
145f7f6
to
3c8e1dd
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3984630
branch
3 times, most recently
from
13408ca
to
7c3e510
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3984630
branch
2 times, most recently
from
16bdc22
to
346a0f0
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3984630
branch
from
346a0f0
to
de72a48
Compare
This has been discussed here: whatwg/html#4184 whatwg/html#8199 The gist of the changes are: 1. Make the dialog focusing steps look at keyboard focusable elements instead of any focusable element. 2. Make the dialog element itself get focus if it has the autofocus attribute set. 3. Make the dialog element itself get focus as a fallback instead of focus being "reset" to the body element. This patch also adds "outline:none" to several WPTs because this patch causes the dialog element to become initially focused in some cases and get a focus ring. I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/CEL3wWHrTAQ Fixed: 1193482 Change-Id: I1fee5981f72039a4467cbb35b2317832dd31bbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3984630 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1100024}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3984630
branch
from
de72a48
to
4a7eb16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been discussed here:
whatwg/html#4184
whatwg/html#8199
The gist of the changes are:
instead of any focusable element.
attribute set.
focus being "reset" to the body element.
This patch also adds "outline:none" to several WPTs because this patch
causes the dialog element to become initially focused in some cases and
get a focus ring.
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/CEL3wWHrTAQ
Fixed: 1193482
Change-Id: I1fee5981f72039a4467cbb35b2317832dd31bbea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3984630
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1100024}