WebCryptoAPI: assert that CryptoKey instances have the expected Symbol.toStringTag #37716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change has not affected any of the wpt.fyi results. |
Co-authored-by: Daniel Huigens <[email protected]>
twiss
approved these changes
Jan 18, 2023
jgerigmeyer
added a commit
to oddbird/wpt
that referenced
this pull request
Jan 18, 2023
* master: (29 commits) WebCryptoAPI: check that CryptoKey instances have the expected Symbol.toStringTag (web-platform-tests#37716) ResizeObserver: Element with size 0x0 should be notified (web-platform-tests#38041) WebCryptoAPI: remove test for OperationError for tagLength 256 (web-platform-tests#37734) [scroll-timeline] Implement animation-range [Web Platform Test] Remove extra indent from shipping-option test [scroll-timeline] Reverse scroll-timeline-axis/name [Web Platform Test] Remove extra indents from delegations tests [Web Platform Test] Just-in-time install for shipping-option test [Web Platform Test] Just-in-time install for delegations test remove auth header from redirected cross-origin requests. Add tests for [Transferable] VideoFrame Make the style editor handle `<font>` at last when there are multiple preserved styles Make css-fonts/animations/font-variation-settings-composition.html less finicky about serialization order for font-variation-settings. [scroll-timeline] Hide support for tree-scoped timeline behind a flag Use script instead of fetch to de-flake firefox Retries in cache test Clean up doc test Fix CR comments Update preload/prefetch-cache.html Add test cases for cross-origin error events ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently come across user's expectation that the Node.js implementation would have the same
Symbol.toStringTagas browsers do for object type detection.Refs: #37710
Refs: nodejs/node#45987
Having this WPT in place would have told us as implementers early that something we've missed is possibly already relied upon in the javascript ecosystem.