[scoped-registry] Implement scoped custom element upgrade #37943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Changes CustomElement::Registry() to return tree-scoped registries
instead of the global registry. As this function is used by a lot
of callers (including upgrade), this allows these callers to use
the scoped registry associated with the tree scope.
Custom element construction stack entries are augmented with the
definition being used, so that later when calling
super()
, wecan still know which custom element definition is being used.
See [scoped-registries] Interaction with HTML element's overridden constructor steps WICG/webcomponents#969 for details.
Bug: 1304439
Change-Id: Id510ecea0f4c5cf6386f77a39d346918c9592e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4144367
Reviewed-by: Joey Arhar <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1137942}