[Gecko Bug 1811545] [wdspec] Enhance stale_element fixture for shadow root nodes.

[moz-wptsync-bot]

Differential Revision: https://phabricator.services.mozilla.com/D167542

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1811545
gecko-commit: 55cec0043044a5dca7fa5a2b4108086d6b8f5f17
gecko-reviewers: webdriver-reviewers, jdescottes

[wpt-pr-bot]

The review process for this patch is being conducted in the Firefox project.

[whimboo]

FYI @sadym-chromium and @foolip for more tests around stale elements and shadow roots.

[whimboo]

@foolip or @nechaev-chromium could one of you please have a look why chromedriver is not able to start Chrome at all for the stability tasks? Thanks.

[nechaev-chromium]

I'm looking into it

[nechaev-chromium]

There are many messages with reading "pthread_create: Resource temporarily unavailable".
It looks like the maximum allowed thread count in the system is exceeded.
This might happen if ChromeDriver crashed and did not close Chrome instances.
I will leave WPT tests running overnight and see if my hypothesis is correct.

[whimboo]

Ah maybe this is triggered by the additional tests that I added which in some cases causes Chrome to unexpectedly crash the current tab? When inspecting the raw log I can see a lot of the following crashes:

79:42.61 INFO STDOUT: E           webdriver.error.WebDriverException: tab crashed (500): tab crashed
79:42.61 INFO STDOUT: E             (Session info: chrome=111.0.5562.0)
79:42.61 INFO STDOUT: E           

[whimboo]

And after a couple of those crashes the following is logged and all the remaining tests are failing:

ERROR test_no_top_browsing_context - setup error: webdriver.error.UnknownErrorException: unknown error (500): unknown error: Chrome failed to start: crashed.

Please let me know of your results and if we can safely merge this PR. At least the wpt-chrome-dev-results don't show any issues.

[jcscottiii]

When I try to replicate the CI job locally, I get the same error.

Steps taken locally:

docker run -it webplatformtests/wpt:0.52 bash
# Get a shell into the container.

/home/test/start.sh https://github.com/web-platform-tests/wpt.git refs/pull/38208/merge
cd web-platform-tests
git branch base_head d2e81383796b458968eb86b0dd7033b6a23df05a
git branch pr_head 9cd69f7265cd57fbd5894003242a8ebe8088e757
git fetch --quiet origin master:master
./tools/ci/run_tc.py --ref=refs/pull/38208/merge --head-rev=9cd69f7265cd57fbd5894003242a8ebe8088e757 --merge-rev=170a89d292550698eff44328b85f98e18085aab8 --oom-killer --xvfb --hosts --browser=chrome --channel=dev --install-certificates -- ./tools/ci/taskcluster-run.py --commit-range base_head chrome dev -- --channel=dev --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md

[nechaev-chromium]

It does not reproduce locally on my Linux computer with ChromeDriver 112.0.5569.0, Chrome 111.0.5562.0 and WPT (webdriver/tests) from gecko/1811545 branch. There are no abandoned Chrome processes.

[whimboo]

So maybe it's an issue with the docker image and some installed dependencies? I wonder if you would also be able to reproduce like @jcscottiii is.

[jcscottiii]

I think the failures are unrelated to this PR.

1. I created [do not merge] debug PR 38208 #38292. This PR has no meaningful changes. Just whitespace. And I see the same error Chrome failed to start: crashed
2. I also tried this PR locally with chrome stable running ./tools/ci/run_tc.py --ref=refs/pull/38208/merge --head-rev=9cd69f7265cd57fbd5894003242a8ebe8088e757 --merge-rev=170a89d292550698eff44328b85f98e18085aab8 --oom-killer --xvfb --hosts --browser=chrome --channel=stable --install-certificates -- ./tools/ci/taskcluster-run.py --commit-range base_head chrome stable -- --channel=stable --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md And I get the same error.

cc: @foolip

[whimboo]

@sadym-chromium your help would be appreciated here so that we can merge this PR. Thanks!

[sadym-chromium]

on it

[sadym-chromium]

I cannot reproduce the Chrome crashes locally. When following the below steps, tests work well (some failures and errors, but no crashes).

When I try to replicate the CI job locally, I get the same error.

Steps taken locally:

docker run -it webplatformtests/wpt:0.52 bash
# Get a shell into the container.

/home/test/start.sh https://github.com/web-platform-tests/wpt.git refs/pull/38208/merge
cd web-platform-tests
git branch base_head d2e81383796b458968eb86b0dd7033b6a23df05a
git branch pr_head 9cd69f7265cd57fbd5894003242a8ebe8088e757
git fetch --quiet origin master:master
./tools/ci/run_tc.py --ref=refs/pull/38208/merge --head-rev=9cd69f7265cd57fbd5894003242a8ebe8088e757 --merge-rev=170a89d292550698eff44328b85f98e18085aab8 --oom-killer --xvfb --hosts --browser=chrome --channel=dev --install-certificates -- ./tools/ci/taskcluster-run.py --commit-range base_head chrome dev -- --channel=dev --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md

[jgraham]

Since we think the crashes are unrelated to this PR, I'm going to force-merge.