dom, domxpath: Update lookupNamespaceURI() and createNSResolver() #38636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for whatwg/dom#1165. lookupNamespaceURI(): Element should handle "xml" and "xmlns" by default. createNSResolver(): It should return the argument as is, and should not add "xml" prefix support.
4 tasks
annevk
approved these changes
Feb 22, 2023
annevk
pushed a commit
to whatwg/dom
that referenced
this pull request
Feb 22, 2023
webkit-early-warning-system
pushed a commit
to cdumez/WebKit
that referenced
this pull request
Feb 26, 2023
…ver() https://bugs.webkit.org/show_bug.cgi?id=252716 Reviewed by Darin Adler. Update Node.lookupNamespaceURI() and XPathEvaluatorBase.createNSResolver() per: whatwg/dom#1165 web-platform-tests/wpt#38636 - lookupNamespaceURI(): Element should handle "xml" and "xmlns" by default. - createNSResolver(): It should return the argument as is, and should not add "xml" prefix support. * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-lookupNamespaceURI-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-lookupNamespaceURI.html: * LayoutTests/imported/w3c/web-platform-tests/domxpath/xpathevaluatorbase-creatensresolver-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/domxpath/xpathevaluatorbase-creatensresolver.html: Added. * Source/WebCore/dom/Document.h: (WebCore::Document::createNSResolverForBindings const): * Source/WebCore/dom/Node.cpp: (WebCore::locateDefaultNamespace): * Source/WebCore/xml/XPathEvaluator.h: (WebCore::XPathEvaluator::createNSResolverForBindings const): * Source/WebCore/xml/XPathEvaluatorBase.idl: Canonical link: https://commits.webkit.org/260848@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for whatwg/dom#1165.
lookupNamespaceURI():
Element should handle "xml" and "xmlns" by default.
createNSResolver():
It should return the argument as is, and should not add "xml" prefix support.