Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement CSSTransitionDiscrete which enables transitions on discrete properties." #38802

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 3, 2023

This reverts commit 367c58094d184ff90ef132789985bd4fc53c721a.

Reason for revert: Causing failures in blink-web-tests on many bots, for example: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/127213/overview

Original change's description:

Implement CSSTransitionDiscrete which enables transitions on discrete properties.

This feature enables transitioning discrete properties.

This is based on the resolved CSSWG issue:

You can test display transitions with this CL on:
https://output.jsbin.com/buquher/quiet

Original patch: http://crrev.com/c/4182089

Bug: 1399631, 1413556
Change-Id: Icf5364b970233186794fa9faaa016e0e6542ec2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219315
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1112645}

Bug: 1399631, 1413556
Change-Id: I45cbf126b16402a88c7105d8204b342a79ded3d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4305045
Commit-Queue: Adam Rice <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1112668}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

…discrete properties."

This reverts commit 367c58094d184ff90ef132789985bd4fc53c721a.

Reason for revert: Causing failures in blink-web-tests on many bots, for example: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/127213/overview

Original change's description:
> Implement CSSTransitionDiscrete which enables transitions on discrete properties.
>
> This feature enables transitioning discrete properties.
>
> This is based on the resolved CSSWG issue:
> - Transition discrete properties: w3c/csswg-drafts#4441
>
> You can test display transitions with this CL on:
> https://output.jsbin.com/buquher/quiet
>
> Original patch: http://crrev.com/c/4182089
>
> Bug: 1399631, 1413556
> Change-Id: Icf5364b970233186794fa9faaa016e0e6542ec2b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219315
> Reviewed-by: Robert Flack <[email protected]>
> Commit-Queue: Joey Arhar <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1112645}

Bug: 1399631, 1413556
Change-Id: I45cbf126b16402a88c7105d8204b342a79ded3d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4305045
Commit-Queue: Adam Rice <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1112668}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants