Make ::backdrop stay in top layer while animating out #40369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 2, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4585724
branch
2 times, most recently
from
5c46a62
to
550f14d
Compare
4 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4585724
branch
2 times, most recently
from
cb7b64c
to
7ba891f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4585724
branch
from
7ba891f
to
a74e5fb
Compare
This patch adds a new internal pseudo class which matches popovers while they are still in the top layer after they have been closed in order to also make the corresponding ::backdrop stay in the top layer. This is based on futhark's patch: https://chromium-review.googlesource.com/c/chromium/src/+/4554016 HTML spec PR: whatwg/html#9387 Fixed: 1449145 Change-Id: I8e4831e960c5d18fb077f023c119fd0e678541df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585724 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1158640}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4585724
branch
from
a74e5fb
to
c543914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new internal pseudo class which matches popovers while
they are still in the top layer after they have been closed in order to
also make the corresponding ::backdrop stay in the top layer.
This is based on futhark's patch:
https://chromium-review.googlesource.com/c/chromium/src/+/4554016
HTML spec PR: whatwg/html#9387
Fixed: 1449145
Change-Id: I8e4831e960c5d18fb077f023c119fd0e678541df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585724
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158640}