Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miscellaneous lint, clean-up and modernization changes to webdriver/tests/support #40470

Merged
merged 32 commits into from
Jun 16, 2023
Merged

miscellaneous lint, clean-up and modernization changes to webdriver/tests/support #40470

merged 32 commits into from
Jun 16, 2023

Conversation

thiagowfx
Copy link
Member

No description provided.

@thiagowfx thiagowfx changed the title miscellaneous lint and clean-up changes to webdriver/tests/support miscellaneous lint, clean-up and modernization changes to webdriver/tests/support Jun 9, 2023
@thiagowfx thiagowfx requested a review from whimboo June 9, 2023 10:53
@thiagowfx thiagowfx marked this pull request as ready for review June 9, 2023 12:51
@thiagowfx thiagowfx enabled auto-merge (squash) June 9, 2023 13:56
@thiagowfx thiagowfx mentioned this pull request Jun 9, 2023
Open
@thiagowfx thiagowfx mentioned this pull request Jun 9, 2023
Merged
@whimboo
Copy link
Contributor

whimboo commented Jun 12, 2023

@thiagowfx is that PR ready for review or are you still working on it? If it's the latter then please mark the PR as draft. Thanks.

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Jun 12, 2023
@thiagowfx
Copy link
Member Author

@whimboo it's done! I just added two small additional changes just now, but do not plan do add anything else.

@thiagowfx thiagowfx requested a review from whimboo June 12, 2023 15:40
@thiagowfx
inline.py: type annotate
6998bce
@thiagowfx
capture_screenshot: remove unused variable
b5b0e01
@thiagowfx
context_created: add a new test, effectively using type_hint
c54236c
@thiagowfx
reload: create __init__.py file for consistency
b8a7430
@thiagowfx
context_created: remove unused import
a96f87b
@thiagowfx
browsing_context: format
ae0106f
@thiagowfx
errors: remove unused fixture
8ce673b
@thiagowfx
format: adjust blank lines
f0b2f67
@thiagowfx
event_buffer: remove unused constructs
7ef9644
@thiagowfx
javascript: remove unused imports and fixtures
f839c18
@thiagowfx
network_events: remove unused fixtures
b66fc11
@thiagowfx
session: remove unused imports, fixtures and variables
e4fe247
@thiagowfx
response_started: remove unused imports and fixtures
25b726c
@thiagowfx
before_request_sent: adjust blank lines
8ac791c
@thiagowfx
response_completed: remove unused imports and fixtures
56d4fca
@thiagowfx
on_event: do not define unused params
7bc8928
@thiagowfx
on_event: do not define unused params
23b08ea
@thiagowfx
render.html: format
f16bc43
@thiagowfx
print_pdf_runner.html: const -> var
cc22317
@thiagowfx
remove unused imports in response_completed.py
aab8d68
@thiagowfx
Copy link
Member Author

@thiagowfx this PR has a merge conflict now. Can you please resolve it?

Done. Out of habit I force pushed again, but will reiterate there are no modifications other than response_completed.py (removed some extraneous imports while resolving the merge conflict).

@jgraham jgraham disabled auto-merge June 16, 2023 13:37
@jgraham jgraham enabled auto-merge (squash) June 16, 2023 13:38
@jgraham jgraham disabled auto-merge June 16, 2023 13:45
@jgraham jgraham merged commit ff6a3b2 into master Jun 16, 2023
@jgraham jgraham deleted the thiagowfx/support branch June 16, 2023 13:45
@thiagowfx thiagowfx mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo approved these changes

@sadym-chromium sadym-chromium sadym-chromium approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@jrandolf-2 jrandolf-2 Awaiting requested review from jrandolf-2

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@shs96c shs96c Awaiting requested review from shs96c

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

@foolip foolip Awaiting requested review from foolip

Assignees

@whimboo whimboo

@jgraham jgraham

@sadym-chromium sadym-chromium

Labels
infra webdriver webdriver-bidi wg-testing_browser wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thiagowfx @whimboo @nechaev-chromium @sadym-chromium @jgraham @wpt-pr-bot @moz-wptsync-bot