-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lint rule for /> syntax on non-void HTML elements #40498
Conversation
How do I run the lint tests locally? |
@zcorpan running |
I needed to run
Now fixed. Also removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Should be possible to write a test for this by copying other lint rule tests, but I'll leave it to you to judge if that's worthwhile or not.
Done, and confirmed that it works locally with:
Changing the test to expect no errors makes it fail. |
11defd8
to
8078847
Compare
See #40473