Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dialog user-agent styles apply while in top layer #41330

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Make dialog user-agent styles apply while in top layer #41330

merged 1 commit into from
Aug 4, 2023

Commits on Aug 4, 2023

  1. Make dialog user-agent styles apply while in top layer 

    This makes it so that while the dialog element is doing an exit
animation, its positioning etc. styles from the user-agent stylesheet
still apply so it doesnt jump to a different spot while animating out.
The :modal class is removed during this time which is why it was a
problem before. We also can't just make all dialog elements always have
these styles applied, because then they would also apply to non-modal
dialogs.

Spec: whatwg/html#9387

Fixed: 1451910
Change-Id: I4d2b240ab17879d6cf08f94f32d7c7577e9f53ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4739784
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1179848}
    @josepharhar @chromium-wpt-export-bot
    josepharhar authored and chromium-wpt-export-bot committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0b12ab1 View commit details
    Browse the repository at this point in the history