[WebDriver BiDi] Update tilt tests #42360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
OrKoN
reviewed
Oct 5, 2023
|
Deferring to @whimboo @juliandescottes who appear to have worked on these tests initially. |
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
5d54471
to
5b468b1
Compare
whimboo
requested changes
Oct 5, 2023
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
5b468b1
to
46438e5
Compare
whimboo
reviewed
Oct 5, 2023
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
46438e5
to
1d99619
Compare
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
1d99619
to
d4bdd89
Compare
whimboo
reviewed
Oct 6, 2023
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
2 times, most recently
from
09a3e24
to
66dae8f
Compare
|
Is it still blocked by w3c/pointerevents#485 ? |
No, it's not. For more context, in Chromium, we wanted to lower the precision of the angles because OSes usually give float32 accuracy for those values. However, I found that macOS provides doubles on 64-bit machines, so I closed the PR and upgraded the types in Chromium. |
whimboo
reviewed
Oct 9, 2023
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
66dae8f
to
202067d
Compare
|
@jrandolf I just noticed that we have the same tests for WebDriver classic. We probably want to update those at the same time? |
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
202067d
to
1315b20
Compare
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
1315b20
to
7ffc84a
Compare
whimboo
requested changes
Nov 2, 2023
jrandolf-2
force-pushed
the
jrandolf/update-tilt-tests
branch
from
7ffc84a
to
18ee800
Compare
whimboo
approved these changes
Nov 7, 2023
OrKoN
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.