Change expectation for invalid/missing shadowRootMode IDL to null #42619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 19, 2023
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4954120
branch
2 times, most recently
from
805a632
to
7c70510
Compare
Per the spec discussion: whatwg/html#5465 (comment) this changes the expectation for the tests to be: document.createElement("template").shadowRootMode === "" rather than === null. Note that this CL does not change Chromium's behavior, and as such I cannot check if there are other tests that implicitly also do a similar check. More tests might need to change once I (or someone) implements this new behavior in a browser. Bug: 1379513 Change-Id: I0ea1371d612d524fdecc287f3f1790d601c64982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954120 Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1213658}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4954120
branch
from
7c70510
to
c843715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the spec discussion:
whatwg/html#5465 (comment)
this changes the expectation for the tests to be:
document.createElement("template").shadowRootMode === ""
rather than === null.
Note that this CL does not change Chromium's behavior, and as such
I cannot check if there are other tests that implicitly also
do a similar check. More tests might need to change once I (or
someone) implements this new behavior in a browser.
Bug: 1379513
Change-Id: I0ea1371d612d524fdecc287f3f1790d601c64982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954120
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1213658}