Fix for regression from PR 43853 that didn't obey minimized and fullscreen windows #43894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
jrandolf-2,
juliandescottes,
sadym-chromium and
shs96c
lutien
approved these changes
Jan 9, 2024
|
There seems to be an issue with maximized as well. I would suggest to check for that as well, and actually make all the additional logic Chrome only given that for both Safari and Firefox the problem doesn't appear. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
…d and fullscreen windows (#43894) Fix for regression from PR 43853 that didn't obey minimized, maximized and fullscreen windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression from PR #43853.
CC @lutien