Correct id of img element in aria-labelledby test #45854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test includes an aria-labelledby reference to id "nested_image_label3" but that id doesn't exist. Instead, "nested_image_label_3" exists. This commit updates the id, removing the underscore to fit the pattern of the test file.
cookiecrook
approved these changes
Apr 24, 2024
|
@nmlapre this was clearly just a typo, so merging... (thanks for the PR) However, I've raised the following issue... There was enough confusion between editors about the "traversal" language that I'm not 100% sure all the remaining tests are aligned with AccName. |
|
Thanks for raising that issue! I tried implementing fixes for those in Gecko about a month ago but encountered some ambiguity that led me to table it for a bit. IIRC, it had to do with language surrounding "Each node in the subtree is consulted only once." and "...the current node is not already part of an ongoing aria-labelledby or aria-describedby traversal..." Anyhow, I need to have another think about those tests before I give an opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: web-platform-tests/interop-accessibility#122
This test includes an aria-labelledby reference to id
nested_image_label3but that id doesn't exist. Instead,nested_image_label_3exists. This commit updates the id, removing the underscore to fit the pattern of the test file.