Add checkmark to base-select options #46609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5578818
branch
from
05925e7
to
3eb8539
Compare
This is being discussed in OpenUI here: openui/open-ui#863 The discussion suggested that we should use a unicode checkmark instead of an SVG, so that's what this patch does. It might be better to use ::marker instead of ::before, but we might also end up with something else entirely and I think that reusing ::marker would be harder to implement, so I am using ::before for now. Bug: 1511354 Change-Id: I29c1dfc26208e6fc13cf42782a3d9d6fae2e711c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5578818 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1313329}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5578818
branch
from
3eb8539
to
171dc61
Compare
wpt-pr-bot
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being discussed in OpenUI here:
openui/open-ui#863
The discussion suggested that we should use a unicode checkmark instead
of an SVG, so that's what this patch does.
It might be better to use ::marker instead of ::before, but we might
also end up with something else entirely and I think that reusing
::marker would be harder to implement, so I am using ::before for now.
Bug: 1511354
Change-Id: I29c1dfc26208e6fc13cf42782a3d9d6fae2e711c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5578818
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1313329}